nodedev_xml: extend MdevXML with attr elements #3723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitterl
force-pushed
the
extend_mdev_capability_xml
branch
from
df351f8
to
07c94cf
Compare
smitterl
force-pushed
the
extend_mdev_capability_xml
branch
from
07c94cf
to
e8cfdaa
Compare
|
Tested via autotest/tp-libvirt#5040 |
|
@chloerh Could you help review it as you also have many experience on this? |
chloerh
reviewed
Jul 25, 2023
virttest/libvirt_xml/nodedev_xml.py
Outdated
| return newone | ||
|
|
||
|
|
||
| class AttrXML(base.LibvirtXMLBase): |
There was a problem hiding this comment.
According to the xml of <attr>, seems no need to define this class, we could simply define the accessor with 'has_subclass = False' and with shorter marshal functions, if <attr> doesn't have sub-element. What do you think?
There was a problem hiding this comment.
Like this:
accessors.XMLElementList('vcpupins', self, parent_xpath='/',
marshal_from=self.marshal_from_vcpupins,
marshal_to=self.marshal_to_vcpupins)
There was a problem hiding this comment.
Thank you for the suggestion. It works well.
There was a problem hiding this comment.
Thanks for taking my suggestion, btw there's inspekt issue needs to be resovle.
smitterl
force-pushed
the
extend_mdev_capability_xml
branch
from
e8cfdaa
to
2daf499
Compare
Add support for attribute elements of the mediated device capability xml, e.g.: ``` <attr name='assign_adapter' value='3'/> <attr name='assign_domain' value='43'/> ``` Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
extend_mdev_capability_xml
branch
from
2daf499
to
67c76ba
Compare
chloerh
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for attribute elements of the mediated device capability xml, e.g.: